Skip to content

implement setleafcontext on model #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

implement setleafcontext on model #1051

wants to merge 4 commits into from

Conversation

penelopeysm
Copy link
Member

Closes #993.

@penelopeysm penelopeysm changed the base branch from main to breaking September 24, 2025 17:51
@penelopeysm penelopeysm force-pushed the py/setleafcontext-model branch from 7045b5f to 2168693 Compare September 24, 2025 17:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 24, 2025 •
edited
Loading

Benchmark Report for Commit e95495a

Computer Information

Julia Version 1.11.7
Commit f2b3dbda30a (2025-09-08 12:10 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

┌───────────────────────┬───────┬─────────────┬───────────────────┬────────┬────────────────┬─────────────────┐
│                 Model │   Dim │  AD Backend │           VarInfo │ Linked │ t(eval)/t(ref) │ t(grad)/t(eval) │
├───────────────────────┼───────┼─────────────┼───────────────────┼────────┼────────────────┼─────────────────┤
│ Simple assume observe │     1 │ forwarddiff │             typed │  false │            9.4 │             1.5 │
│           Smorgasbord │   201 │ forwarddiff │             typed │  false │          671.1 │            42.3 │
│           Smorgasbord │   201 │ forwarddiff │ simple_namedtuple │   true │          435.3 │            53.1 │
│           Smorgasbord │   201 │ forwarddiff │           untyped │   true │         1244.3 │            28.6 │
│           Smorgasbord │   201 │ forwarddiff │       simple_dict │   true │         6929.7 │            29.1 │
│           Smorgasbord │   201 │ reversediff │             typed │   true │         1078.5 │            39.7 │
│           Smorgasbord │   201 │    mooncake │             typed │   true │         1030.8 │             4.6 │
│    Loop univariate 1k │  1000 │    mooncake │             typed │   true │         6055.4 │             4.3 │
│       Multivariate 1k │  1000 │    mooncake │             typed │   true │         1008.9 │             9.1 │
│   Loop univariate 10k │ 10000 │    mooncake │             typed │   true │        68159.4 │             3.9 │
│      Multivariate 10k │ 10000 │    mooncake │             typed │   true │         8913.5 │            10.0 │
│               Dynamic │    10 │    mooncake │             typed │   true │          144.8 │            12.1 │
│              Submodel │     1 │    mooncake │             typed │   true │           12.9 │             5.1 │
│                   LDA │    12 │ reversediff │             typed │   true │         1055.3 │             2.1 │
└───────────────────────┴───────┴─────────────┴───────────────────┴────────┴────────────────┴─────────────────┘

@penelopeysm
Copy link
Member Author

Just realised that setleafcontext is not documented anywhere, actually, should probably do it in this PR too

@penelopeysm penelopeysm marked this pull request as draft September 24, 2025 18:02
@codecov Codecov
Copy link

codecov bot commented Sep 24, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (breaking@5a98037). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/threadsafe.jl 0.00% 2 Missing ⚠️
src/sampler.jl 0.00% 1 Missing ⚠️
src/test_utils/contexts.jl 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             breaking    #1051   +/-   ##
===========================================
  Coverage            ?   34.55%           
===========================================
  Files               ?       39           
  Lines               ?     3788           
  Branches            ?        0           
===========================================
  Hits                ?     1309           
  Misses              ?     2479           
  Partials            ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@penelopeysm penelopeysm force-pushed the py/setleafcontext-model branch from 2168693 to b891a52 Compare September 24, 2025 22:51
@github-actions GitHub Actions
Copy link
Contributor

DynamicPPL.jl documentation for PR #1051 is available at:
https://TuringLang.github.io/DynamicPPL.jl/previews/PR1051/

@penelopeysm
Copy link
Member Author

this is actually a terrible branch name, apologies, will reopen

@yebai yebai deleted the py/setleafcontext-model branch September 30, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@penelopeysm penelopeysm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setleafcontext(::Model, ::AbstractContext)
1 participant
@penelopeysm